Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate headers and servers block #30

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

AS-AlStar
Copy link
Contributor

Added generating parameters on the file for required specific headers.
Added generating block with servers on the file .

@k0kubun
Copy link
Collaborator

k0kubun commented Aug 21, 2021

Could you make tests pass first?

@AS-AlStar
Copy link
Contributor Author

Ok, please, approve running workflows.

Copy link
Collaborator

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k0kubun k0kubun merged commit cb634d0 into exoego:master Aug 23, 2021
@k0kubun
Copy link
Collaborator

k0kubun commented Aug 23, 2021

Oh actually, before releasing this, may I confirm whether you intended to use the headers config for response headers as well or not? If you are only interested in documenting request headers using this feature, can we rename the config to request_headers so that we can separately have response_headers?

@AS-AlStar
Copy link
Contributor Author

AS-AlStar commented Aug 26, 2021

I use only for request headers. Yes, you are right, let's rename to request_headers. Should I create a new pull request or will you fix it yourself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants